josh/ytplayer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Restart failed saves through a guarded server retry

Browse Source
This commit is contained in:
Jonathan Sykes
2026-10-03 19:16:08 +08:00
parent 5485a3c2f4
commit f341b0c76e
7 changed files with 162 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/download-retry.spec.js Normal file
View File

@@ -0,0 +1,46 @@
const { test, expect } = require('@playwright/test');
const { openClassic } = require('./helpers/classic-fixture');
const id = 'wZzRoXymOUU';
for (const layout of ['classic', 'glass-stage']) for (const screen of ['downloads', 'settings']) {
test(`${layout} ${screen}: Retry starts a fresh server job before preparation`, async ({ page }) => {
await page.setViewportSize({ width: 390, height: 844 });
await openClassic(page, { settings: { autoPreload: false } });
const requests = [];
await page.route(`**/api/download/${id}/retry`, route => {
requests.push('retry:' + route.request().method());
return route.fulfill({ status: 202, contentType: 'application/json', body: '{"ok":true,"state":"working"}' });
});
await page.route(`**/api/download/${id}/prepare*`, route => {
requests.push('prepare');
return route.fulfill({ contentType: 'application/json', body: '{"ok":true,"state":"ready","etag":"fixture","size":4096,"ext":"mp4"}' });
});
await page.evaluate(({ layout, screen, id }) => {
data.settings.layout = layout; applyAppearance();
window.OPFS.isSupported = () => true;
window.OPFS.downloadVideo = async () => ({ ok: true, size: 4096 });
SaveQueue.add({ id, title: 'Rock Medley', channel: 'Petra - Topic' });
SaveQueue.state(id, 'failed', `ERROR: [youtube] ${id}: Video unavailable`);
view = { type: screen }; render();
}, { layout, screen, id });
if (screen === 'settings') await page.locator('[data-section="downloads-storage"]').click();
await page.getByRole('button', { name: 'Retry Rock Medley', exact: true }).click();
await expect.poll(() => requests).toEqual(['retry:POST', 'prepare']);
await expect.poll(() => page.evaluate(id => cachedIds.has(id), id)).toBe(true);
expect(await page.evaluate(() => SaveQueue.pending().length)).toBe(0);
});
}
test('normal resumptions do not force the server to restart a cache job', async ({ page }) => {
await openClassic(page, { settings: { autoPreload: false } });
let retries = 0;
await page.route(`**/api/download/${id}/retry`, route => { retries++; return route.fulfill({ contentType: 'application/json', body: '{"ok":true}' }); });
await page.route(`**/api/download/${id}/prepare*`, route => route.fulfill({ contentType: 'application/json', body: '{"ok":true,"state":"ready","etag":"fixture","size":4096}' }));
await page.evaluate(async id => {
window.OPFS.isSupported = () => true;
window.OPFS.downloadVideo = async () => ({ ok: true, size: 4096 });
await preload({ id, title: 'Rock Medley' }, { quiet: true });
}, id);
expect(retries).toBe(0);
expect(await page.evaluate(id => cachedIds.has(id), id)).toBe(true);
});